-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: Track the balance of the deferred chain value pool #8729
Conversation
…tructs, splits them into pre/post NU6 funding streams, and adds them as a field on `testnet::Parameters`
…onversion logic with constraints. Minor refactors
…red Testnets, but that being okay since configured testnet parameters are checked when they're being built
…ams, updates the `miner_fees_are_valid()` and `subsidy_is_valid()` functions to check that the deferred pool contribution is valid and that there are no unclaimed block subsidies after NU6 activation, and adds some TODOs
…too, adds Mainnet/Testnet NU6 activation heights, fixes lints/compilation issue
…est_funding_stream_values()` to use a configured testnet with the post-NU6 Mainnet funding streams height range
… as a block submission
Can we rebase to get rid of extra commits ? |
I'd prefer that we avoid a rebase since there would be a lot of major conflicts with a relatively high chance of one being resolved incorrectly. We could try squashing the changes? (Though I think this is fine as-is). |
Thank you for this change! The full sync on Mainnet with almost all of the changes succeeded here, and we just checked that the Testnet sync passed as well in GCP (though Github is having trouble updating the test's status). It looks like the full sync tests that are still pending in Github aren't required for merging into the main branch anyway, so this should merge soon. |
Motivation
Close #8688.
Depends-On: #8694.
Solution
There are two main changes in this PR:
This PR also bumps the major database format version.
High-level Description
zebra-consensus
during the semantic validation of both checkpointed and non-checkpointed blocks.zebra-state
in the validated blocks.ValueBalance
struct has a new field, so it has a new serialization format for storing the struct in the database. This new format is backward-compatible but not forward-compatible with the currently supported Zebra versions, so this PR bumps the major database format version from 25.3.0 to 26.0.0.Tests
Current tests should suffice.
PR Author's Checklist
PR Reviewer's Checklist