Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): Add a stop rpc method #8839

Merged
merged 5 commits into from
Sep 9, 2024
Merged

feat(rpc): Add a stop rpc method #8839

merged 5 commits into from
Sep 9, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

Close #8836

Solution

Add an rpc that terminate the running process. Only work if the network is the regtest.

Tests

Manually tested.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage added C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces labels Sep 4, 2024
@oxarbitrage oxarbitrage requested a review from a team as a code owner September 4, 2024 20:28
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team September 4, 2024 20:28
@github-actions github-actions bot added the C-feature Category: New features label Sep 4, 2024
@oxarbitrage oxarbitrage self-assigned this Sep 4, 2024
upbqdn
upbqdn previously approved these changes Sep 5, 2024
View reviewed changes
zebra-rpc/src/methods.rs Show resolved Hide resolved
@upbqdn upbqdn mentioned this pull request Sep 5, 2024
Closed
upbqdn
upbqdn previously approved these changes Sep 5, 2024
View reviewed changes
zebra-rpc/src/methods.rs Outdated Show resolved Hide resolved
@oxarbitrage @upbqdn
add a ticket number to the TODO
87a0405 
Co-authored-by: Marek <mail@marek.onl>
mergify bot added a commit that referenced this pull request Sep 5, 2024
@mergify
Merge of #8839
7599bf1
@mergify mergify bot mentioned this pull request Sep 5, 2024
Closed
@oxarbitrage
Copy link
Contributor Author

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 9, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 554a37d into main Sep 9, 2024
192 checks passed
@mergify mergify bot deleted the stop-rpc branch September 9, 2024 13:02
dmidem pushed a commit to QED-it/zebra that referenced this pull request Oct 29, 2024
@oxarbitrage @upbqdn
@mpguerra @dmidem
feat(rpc): Add a stop rpc method (ZcashFoundation#8839)
4b907f6 
* add a `stop` rpc method

* add todo comment

* add a ticket number to the TODO

Co-authored-by: Marek <mail@marek.onl>

---------

Co-authored-by: Marek <mail@marek.onl>
Co-authored-by: Pili Guerra <mpguerra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 left review comments

@upbqdn upbqdn upbqdn approved these changes

Assignees

@oxarbitrage oxarbitrage

Labels
A-rpc Area: Remote Procedure Call interfaces C-feature Category: New features C-testing Category: These are tests P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement stop RPC method
4 participants
@oxarbitrage @arya2 @upbqdn @mpguerra