fix(rpc): modify shutdown used in stop()
#8863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
added
C-testing
dmidem
pushed a commit
to QED-it/zebra
that referenced
this pull request
Oct 29, 2024
* modify shutdown used in `stop()` * use conditional compilation * add note * fix conditional compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
std::process::exitI introduced for thestopRPC method is not a good idea for the rpc testing because (among other issues) it terminates immediately and the tests require for the method to return before actually finishing with the current process.Additionally this is a more graceful shutdown and will close #8850
Solution
Terminate the process by sending a
SIGINTsignal.PR Author's Checklist
PR Reviewer's Checklist