Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to limit checkpoints to Sapling activation #931

Merged
merged 3 commits into from
Aug 24, 2020

Conversation

teor2345
Copy link
Contributor

Closes #911.
Closes #890.

@teor2345 teor2345 added A-dependencies Area: Dependency file updates E-med A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement labels Aug 20, 2020
@teor2345 teor2345 added this to the Validate transactions. milestone Aug 20, 2020
@teor2345 teor2345 requested a review from a team August 20, 2020 03:16
@teor2345 teor2345 self-assigned this Aug 20, 2020
@teor2345 teor2345 mentioned this pull request Aug 20, 2020
51 tasks
@oxarbitrage

This comment has been minimized.

@teor2345 teor2345 changed the base branch from main to dependabot/cargo/serde-1.0.115 August 20, 2020 21:32
@teor2345 teor2345 changed the base branch from dependabot/cargo/serde-1.0.115 to main August 20, 2020 21:32
(The option doesn't do anything yet.)
* add CheckpointList::new_up_to(limit: NetworkUpgrade)
* if checkpoint_sync is false, limit checkpoints to Sapling
* update tests for CheckpointList and chain::init
@teor2345 teor2345 force-pushed the checkpoint-limit-config branch from 29180f8 to f0bf547 Compare August 20, 2020 21:36
@teor2345

This comment has been minimized.

zebra-consensus/src/chain/tests.rs Show resolved Hide resolved
zebra-consensus/src/checkpoint/list.rs Show resolved Hide resolved
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teor2345 teor2345 merged commit 78201b4 into ZcashFoundation:main Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration option for checkpoint limit. Make the state Config load unspecified fields from defaults
4 participants