Fix Recursive source clang-tidy #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwrsandman
force-pushed
the
recursive-source-config
branch
from
48b284f to
7765f56
Compare
ZedThree
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue when trying to run clang-tidy without
--checksand--config-file.This is the case when you want to use the
.clang-tidyconfigs in a recursive per-directory way.In #96, I added the ability to set both checks and config to empty strings which did this, however, switching to
shell=False, means that empty strings still count as arguments.This ends up with
''being sent to clang-tidy as an agument which clang-tidy interprets as a file name ($PWD + ''to check. It then emits and error that the current directory cannot be opened.This PR makes sure that in this case, the
''argument is not set and prints a more useful message in that case.