Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override original env variables #111

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Don't override original env variables #111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
882160c
Don't override original env variables
bwrsandman Jan 18, 2024
d8b8a3c
Apply black changes
bwrsandman Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion post/clang_tidy_review/clang_tidy_review/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,14 @@ def build_clang_tidy_warnings(
start = datetime.datetime.now()
try:
with message_group(f"Running:\n\t{args}"):
env = dict(os.environ)
env["USER"] = username
subprocess.run(
args,
capture_output=True,
check=True,
encoding="utf-8",
env={"USER": username},
env=env,
)
except subprocess.CalledProcessError as e:
print(
Expand Down