Add experimental support for annotations #71
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
This is a pretty rough and ready implementation. Annotations don't support markdown, so they don't look great as I've just converted the comments straight to annotations. Using a different formatter might make them look nicer.
Also, the column isn't reported, but that could be solved with a different formatter.
Currently, if there are any issues, the status is set to
neutral
, but maybe it should befailed
, or have a user setting to choose which one (error_on_warnings
?).I'm going to release this in v0.12 now, as I won't have much time to improve this for a while. PRs to make this feature better are more than welcome!