Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental support for annotations #71

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Add experimental support for annotations #71

merged 1 commit into from
Mar 20, 2023

Conversation

ZedThree
Copy link
Owner

Closes #51

This is a pretty rough and ready implementation. Annotations don't support markdown, so they don't look great as I've just converted the comments straight to annotations. Using a different formatter might make them look nicer.

Also, the column isn't reported, but that could be solved with a different formatter.

Currently, if there are any issues, the status is set to neutral, but maybe it should be failed, or have a user setting to choose which one (error_on_warnings?).

I'm going to release this in v0.12 now, as I won't have much time to improve this for a while. PRs to make this feature better are more than welcome!

@ZedThree ZedThree merged commit 27ed107 into master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report the output via GitHub annotations
1 participant