Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes JabRef#676
Refactored
CitationKeyGeneratorTestto use parameterized tests with@ParameterizedTestand@MethodSource, reducing code duplication while maintaining full test coverage. This improves test readability and maintainability by consolidating repetitive test methods into data-driven parameterized tests.Collaboration: This refactoring was completed in collaboration with @hisunll, combining our work on different sections of the test class.
Steps to test
This is a test refactoring PR with no functional changes to the application.
./gradlew test --tests CitationKeyGeneratorTestMandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)