Skip to content

Contribution to issue 676#2

Draft
Zeglow wants to merge 5 commits intomainfrom
contribution-to-issue-676
Draft

Contribution to issue 676#2
Zeglow wants to merge 5 commits intomainfrom
contribution-to-issue-676

Conversation

@Zeglow
Copy link
Owner

@Zeglow Zeglow commented Oct 15, 2025

Closes JabRef#676

Refactored CitationKeyGeneratorTest to use parameterized tests with @ParameterizedTest and @MethodSource, reducing code duplication while maintaining full test coverage. This improves test readability and maintainability by consolidating repetitive test methods into data-driven parameterized tests.
Collaboration: This refactoring was completed in collaboration with @hisunll, combining our work on different sections of the test class.

Steps to test

This is a test refactoring PR with no functional changes to the application.

  1. Run the test suite: ./gradlew test --tests CitationKeyGeneratorTest
  2. Verify all tests pass
  3. Review the refactored code to ensure:
    • All original test cases are preserved
    • Parameterized tests are properly structured
    • Method sources correctly provide test data
  4. Optionally, compare the test coverage before and after to confirm no regression

Mandatory checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bibliography within a bibliography

1 participant