Redo the arithmetic interface for curv
#121
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a unified trait for our BigInt backend in a way that allows us to abstract over the backend.
This problems with using features:
curv
had to either use the default gmp backend or explictly replace it withnum-bigint
, or add their own features that change the features in our library.The combination of these meant that in practice it was hard to actually allow the end user(binaries) to choose their desired backend.
Furthermore, this change will allow users to implement the
BigInt
trait to their own backends, and allows us to add more backends more easily.I'm still debating myself if it's better to use a trait or a wrapper like
struct BigInt<B: BigIntBackend>(B)
that will use the trait to provide method and trait implementations.I also replaced https://crates.io/crates/rust-gmp-kzen with https://crates.io/crates/rug which is a nice wrapper around libgmp and is actively maintained