Adding global context secp256k1 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elichai Is the serde_json necessary? what is his purpose? |
|
It's used in the tests so I moved it from the dependencies to the dev-dependencies |
|
got it, thanks. |
LLFourn
reviewed
Jul 24, 2019
| CONTEXT = Some(Secp256k1::verification_only()); | ||
| }); | ||
| unsafe { CONTEXT.as_ref().unwrap() } | ||
| } |
There was a problem hiding this comment.
Drive by comment: Did you consider using lazy_static for this?
e.g. https://github.com/comit-network/comit-rs/blob/master/vendor/secp256k1_support/src/lib.rs#L15
There was a problem hiding this comment.
Yes I have. that's basically what's lazy_static is doing and this doesn't require a new dependency
|
I am approving this PR given the following pre-condition:
|
gbenattar
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #44
Before this for every multiplication you created the context. which is a very hungry operation (cpu, memory etc).
Instead we're creating a context only once and keep using that.
this context is thread safe. you can pass it around however you want.
the only constraint are:
There is no promise about the exact memory size and representation, meaning that you cannot save it to disk and reload later.
no one should try and modify it's memory(not a problem in rust)