Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ring to 0.13 #5

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Update ring to 0.13 #5

merged 1 commit into from
Jul 26, 2018

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Jul 26, 2018

Following ZenGo-X/multi-party-ecdsa#27 (comment) and cargo doc failure on this repository:

$ cargo +nightly doc
 Documenting ring v0.12.1
    Checking paillier v0.2.0-pre (https://github.com/mortendahl/rust-paillier?branch=dev#0916f46c)
    Checking cryptography-utils v0.1.0 (https://github.com/KZen-networks/cryptography-utils#51adbc95)
error: `[Debug]` cannot be resolved, ignoring it...
   |
note: lint level defined here
  --> /home/roman/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.12.1/src/lib.rs:63:5
   |
63 |     warnings,
   |     ^^^^^^^^
   = note: #[forbid(intra_doc_link_resolution_failure)] implied by #[forbid(warnings)]
   = note: the link appears in this line:
           
            themselves through the [`Display`] and [`Debug`] traits, and may provide
                                                    ^^^^^^^
   = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`

error: Could not document `ring`.

Thanks @GutteApps for fixing the issue!

@romanz romanz requested a review from gbenattar July 26, 2018 09:52
@romanz romanz self-assigned this Jul 26, 2018
@gbenattar gbenattar merged commit 3869226 into ZenGo-X:master Jul 26, 2018
romanz pushed a commit to romanz/rust-paillier that referenced this pull request Jul 26, 2018
Update ring crate to 0.13
4601a65 
Following ZenGo-X/curv#5, the build fails on Travis:
```
error: multiple packages link to native library `ring-asm`, but a native library can be linked only once
package `ring v0.13.2`
    ... which is depended on by `cryptography-utils v0.1.0 (https://github.com/KZen-networks/cryptography-utils#3869226f)`
    ... which is depended on by `multi-party-ecdsa v0.1.0 (file:///home/travis/build/KZen-networks/multi-party-ecdsa)`
links to native library `ring-asm`
package `ring v0.12.1`
    ... which is depended on by `paillier v0.2.0-pre (https://github.com/mortendahl/rust-paillier?branch=dev#0916f46c)`
    ... which is depended on by `multi-party-ecdsa v0.1.0 (file:///home/travis/build/KZen-networks/multi-party-ecdsa)`
also links to native library `ring-asm`
```
https://travis-ci.com/KZen-networks/multi-party-ecdsa/jobs/136548291#L495
@romanz romanz mentioned this pull request Jul 26, 2018
Merged
@romanz
Copy link
Contributor Author

romanz commented Jul 26, 2018

P.S.
It seems that mortendahl/rust-paillier#50 needs to be applied as well.
Sorry for breaking the build...

mortendahl pushed a commit to mortendahl/rust-paillier that referenced this pull request Jul 26, 2018
@mortendahl
Update ring crate to 0.13 (#50)
de8cd10 
Following ZenGo-X/curv#5, the build fails on Travis:
```
error: multiple packages link to native library `ring-asm`, but a native library can be linked only once
package `ring v0.13.2`
    ... which is depended on by `cryptography-utils v0.1.0 (https://github.com/KZen-networks/cryptography-utils#3869226f)`
    ... which is depended on by `multi-party-ecdsa v0.1.0 (file:///home/travis/build/KZen-networks/multi-party-ecdsa)`
links to native library `ring-asm`
package `ring v0.12.1`
    ... which is depended on by `paillier v0.2.0-pre (https://github.com/mortendahl/rust-paillier?branch=dev#0916f46c)`
    ... which is depended on by `multi-party-ecdsa v0.1.0 (file:///home/travis/build/KZen-networks/multi-party-ecdsa)`
also links to native library `ring-asm`
```
https://travis-ci.com/KZen-networks/multi-party-ecdsa/jobs/136548291#L495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbenattar gbenattar gbenattar approved these changes

Assignees

@romanz romanz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanz @gbenattar @MatanGuttman