Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disabling compile time http request #15

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Support disabling compile time http request #15

merged 2 commits into from
Dec 8, 2022

Commits on Dec 6, 2022

  1. Support disabling compile-time HTTP requests 

    This adds a new configuration flag, `:fetch_latest`, which entirely disables the HTTP request at compile-time that tries to get the latest `public_suffix_list.dat`. This behavior was (sort of) achievable without this flag, by configuring the `:public_suffix_list_url` to the empty charlist, but doing so produced a warning on each compile. With the new flag, there's no error.

This is desirable for our use-case for a couple reasons:

1. We want the development build to match as closely as possible what we'll deploy in prod
2. We don't want the possibility of failing production builds based on the availability of a third-party web host
    @s3cur3
    s3cur3 committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c8bf1d0 View commit details
    Browse the repository at this point in the history

  2. Remove warning about unused module attribute when :fetch_latest is … 

    …false
    @s3cur3
    s3cur3 committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    eb1d3d2 View commit details
    Browse the repository at this point in the history