-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pyawaitable.h support precompiled headers. #46
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for awaitable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test build for this? (See the PyAwaitable test package in tests/extension
.)
This change makes it possible to have pyawaitable included inside of a precompiled header. Precompiled headers can sometimes make large C extensions compile faster so this change could benefit some users.
7e93ea7
to
eb73d2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hold off on this until we get the new build system working. We won't need pyawaitable_abi
at all in the new vendored build.
I actually wonder if we should just make a new |
No need. The vendor script already handles everything. |
This change makes it possible to have pyawaitable included inside of a precompiled header. Precompiled headers can sometimes make large C extensions compile faster so this change could benefit some users.