Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pyawaitable.h support precompiled headers. #46

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AraHaan
Copy link
Collaborator

@AraHaan AraHaan commented Jan 1, 2025

This change makes it possible to have pyawaitable included inside of a precompiled header. Precompiled headers can sometimes make large C extensions compile faster so this change could benefit some users.

@AraHaan AraHaan requested a review from ZeroIntensity January 1, 2025 16:06
Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for awaitable ready!

Name Link
🔨 Latest commit eb73d2e
🔍 Latest deploy log https://app.netlify.com/sites/awaitable/deploys/67815a26bf0caf00085c9841
😎 Deploy Preview https://deploy-preview-46--awaitable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
Copy link
Owner

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test build for this? (See the PyAwaitable test package in tests/extension.)

docs/installation.md Show resolved Hide resolved
docs/installation.md Show resolved Hide resolved
docs/installation.md Show resolved Hide resolved
This change makes it possible to have pyawaitable included inside of a precompiled header. Precompiled headers can sometimes make large C extensions compile faster so this change could benefit some users.
@AraHaan AraHaan force-pushed the pch-friendly-include branch from 7e93ea7 to eb73d2e Compare January 10, 2025 17:34
Copy link
Owner

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on this until we get the new build system working. We won't need pyawaitable_abi at all in the new vendored build.

@AraHaan
Copy link
Collaborator Author

AraHaan commented Jan 10, 2025

I actually wonder if we should just make a new vendor.h that actually forward declares every function that will have a definition further down in the vendor file to where the end resulting file would be something similar to the style from Python.h on the new vendor branch.

@ZeroIntensity
Copy link
Owner

No need. The vendor script already handles everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants