Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the peers score by 20 every time an error response is returned #46

Closed
danimesq opened this issue Aug 8, 2017 · 8 comments
Closed

Comments

@danimesq
Copy link
Contributor

danimesq commented Aug 8, 2017

No description provided.

@danimesq
Copy link
Contributor Author

danimesq commented Aug 8, 2017

Reference: HelloZeroNet/ZeroNet#1016.

@danimesq
Copy link
Contributor Author

danimesq commented Aug 8, 2017

Also, automatically change to another peer when a peer is sending the site with missing files.

@danimesq
Copy link
Contributor Author

danimesq commented Aug 8, 2017

Reference: HelloZeroNet/ZeroNet#1036.

@mkg20001
Copy link
Collaborator

mkg20001 commented Aug 8, 2017

Also, automatically change to another peer when a peer is sending the site with missing files.

This is already being done here

Automatically block peers that are returning 404

Instead we could use a peer score system and lower the peers score by 20 every time an error response is returned.
Peers with less then -100 points will be blocked then

@mkg20001 mkg20001 added this to the Stage 1 milestone Aug 8, 2017
@danimesq
Copy link
Contributor Author

danimesq commented Aug 8, 2017

But if the peer use the same Tor IP of others, then all users of a relay will be blocked?

@mkg20001
Copy link
Collaborator

mkg20001 commented Aug 8, 2017

But if the peer use the same Tor IP of others, then all users of a relay will be blocked?

You can't expose your ip via a tor exit node.
Additionally the client would only block the onion address not the relays in between.

@danimesq danimesq changed the title Automatically block peers that are returning 404 Lower the peers score by 20 every time an error response is returned Aug 8, 2017
@danimesq
Copy link
Contributor Author

danimesq commented Aug 8, 2017

Amazing.
I updated the title of this issue.

@mkg20001
Copy link
Collaborator

mkg20001 commented Sep 7, 2017

I will fix this during the rewrite of the discovery stuff, etc. See #91

mkg20001 added a commit that referenced this issue Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants