Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/193 #195

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Pr/193 #195

wants to merge 10 commits into from

Conversation

ThunderMikey
Copy link
Collaborator

@ThunderMikey ThunderMikey commented Oct 2, 2019

improvement on #193

The main issue of #193 is the /home/dockeruser is not writable by dockeruser
and npm complains about not being able to mkdir .cache

@ThunderMikey
Copy link
Collaborator Author

ThunderMikey commented Oct 2, 2019

I have created a DockerHub organisation, post your docker ID or email if you wanna be added to the org.
https://cloud.docker.com/u/zestylogic/repository/docker/zestylogic/fmark-dev

@ps-george
Copy link
Collaborator

My docker id is: psgeorge

Copy link
Collaborator

@ps-george ps-george left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Makes my hacking session look legitimate ;)

Does this work for you as the dev environment you needed to set up?

I approve for merging into my PR, though not sure the whole PR is ready to be approved.

Think we need to make similar/equivalent changes to the docker image which takes the input file and runs FMark -> It works on my machine but e.g. needing a bash command feels a bit messy. But docker does have issues when dealing with needing to manipulate files because we need to share the volumes, so in a way the current solution is "not bad"..

@ThunderMikey
Copy link
Collaborator Author

Does this work for you as the dev environment you needed to set up?

Haven't fully tested it, but it looks pretty functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants