Fix animation transition for middle action in SwippeableRow #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depends on supportsCoinControl and not supportsRouting
The actual value of 100 does not match with any other width animated value. The value should be 200 because if present, the width of others is 200.
Since the routing and coins width animations are correct, the button can appear on the right at the beginning of the swap. Adding opacity transition hide this buttons.
aussedatlo
changed the title
|
Any news on integrating this ? |
|
Behavior reproduced on emulated nexus 5, with LND on polar. |
|
@aussedatlo looks great! thanks for including the videos to illustrate the change have you tried this against LNDHub instances? |
|
LGTM w/ LNDHub! Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue: None
Fix animation transition for middle action in both OnchainSwippeableRow and LightningSwippeableRow.
In fact, the middle button (if supported) had a different animation width compared to other, resulting in strange result.
Before:
error.webm
After:
correction.webm
Tested with Nexus 5 (emulated)
This pull request is categorized as a:
Checklist
npm run tscand made sure my code compiles correctlynpm run lintand made sure my code didn’t contain any problematic patternsnpm run prettierand made sure my code is formatted correctlynpm run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
npm installafter this PR is merged inpackage.jsonandpackage-lock.jsonhave been properly updatedOther: