Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP21/Unified QRs #1076

Merged
merged 6 commits into from
Nov 23, 2022
Merged

BIP21/Unified QRs #1076

merged 6 commits into from
Nov 23, 2022

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Sep 25, 2022

Description

Relates to issue: ZEUS-879

BIP21 spec site
Screenshot_1668056655
Screenshot_1668056678
Screenshot_1668056615
Screenshot_1664149403
Screenshot_1664149408

TODO:

  • Support for generating unified invoices
  • Support for parsing unified invoices, let user select
  • Give users ability to fee on-chain transaction fees in account selection process

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run npm run tsc and made sure my code compiles correctly
  • I’ve run npm run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run npm run prettier and made sure my code is formatted correctly
  • I’ve run npm run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND
  • c-lightning-REST
  • spark
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run npm install after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and package-lock.json have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis marked this pull request as ready for review September 25, 2022 23:47
@benthecarman
Copy link
Contributor

I dont think doing the all caps address or invoice has any benefit here because bitcoin: and lightning= aren't all caps. Even if you made those caps as well the string would be too long for the QR code optimization to take into effect

@kaloudis
Copy link
Contributor Author

@benthecarman haven't tested that yet but I like that this format allows you to grok the other params more easily

@kaloudis kaloudis merged commit 498bb5b into ZeusLN:master Nov 23, 2022
@kaloudis kaloudis deleted the bip21 branch November 23, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants