Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue with error string mismatch in ErrorUtils #1125

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

Talej
Copy link
Contributor

@Talej Talej commented Nov 22, 2022

Description

Relates to issue: ZEUS-0000

IMG_8833

Fixed problem in ErrorUtils when tor bootstrapping failed. Error message wasn't correctly mapping to user friendly message. Updated to include a new case for the actual message thrown. Left original message in there just to be sure no other cases use the original string.

This pull request is categorized as a:

  • [ X] Bug fix

Checklist

  • [ X] I’ve run npm run tsc and made sure my code compiles correctly
  • [ X] I’ve run npm run lint and made sure my code didn’t contain any problematic patterns
  • [X ] I’ve run npm run prettier and made sure my code is formatted correctly
  • [ X] I’ve run npm run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • [ X] Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • [ X] iOS 14 - iPhone 11 Max

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • [X ] LND
  • c-lightning-REST
  • spark
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run npm install after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and package-lock.json have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Nice job!

@kaloudis kaloudis merged commit d0d1c1c into ZeusLN:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants