Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels: maintain channelsType state between renders #1317

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

Talej
Copy link
Contributor

@Talej Talej commented Feb 15, 2023

Description

After viewing a closed channel and then going back to the list of channels the channel list is refreshed and sent back to the open channel view. This change maintains the current channel list view.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis
Copy link
Contributor

  • No need to maintain state on the page if we're tracking it in the store
  • If we're gonna write the state to the store, it should have a proper function in the store
  • As is, there will be issues when switching to implementations that don't support pending/closed channels yet when you're on one of those states

@Talej
Copy link
Contributor Author

Talej commented Feb 17, 2023

  • No need to maintain state on the page if we're tracking it in the store
  • If we're gonna write the state to the store, it should have a proper function in the store
  • As is, there will be issues when switching to implementations that don't support pending/closed channels yet when you're on one of those states

All done... only thing we may still want is to flesh out the reading/writing in the store a bit more? Open to your thoughts here...

@kaloudis
Copy link
Contributor

Looking much better. Perhaps we should create some enums for channel state though

@Talej
Copy link
Contributor Author

Talej commented Feb 17, 2023

enum added in. Also added some missing translations

Copy link
Contributor

@kaloudis kaloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now. Nice work!

@kaloudis kaloudis changed the title maintain channelsType state between re-renders Channels: maintain channelsType state between renders Feb 21, 2023
@kaloudis kaloudis merged commit dd80b91 into ZeusLN:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants