Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Amount Input #1400

Merged
merged 2 commits into from
Apr 8, 2023
Merged

Conversation

kaloudis
Copy link
Contributor

Description

This is a refactor featuring a new component AmountInput that allows a user to input an amount in the unit of their choosing. Appropriate conversions are displayed underneath the field.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.7.5 milestone Mar 26, 2023
@kaloudis kaloudis force-pushed the component-amount-input branch 2 times, most recently from 8dc6e47 to 3d9528c Compare March 26, 2023 06:19
@kaloudis kaloudis marked this pull request as ready for review March 26, 2023 23:11
shubhamkmr04

This comment was marked as duplicate.

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amount not getting updated when we change the units among sats, $, and ₿ by tapping the numbers.

@kaloudis kaloudis force-pushed the component-amount-input branch 3 times, most recently from 3da33e2 to feffd2a Compare April 1, 2023 05:07
@kaloudis kaloudis force-pushed the component-amount-input branch from feffd2a to 46a0ff8 Compare April 5, 2023 16:17
shubhamkmr04

This comment was marked as duplicate.

shubhamkmr04
shubhamkmr04 previously approved these changes Apr 6, 2023
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 01d4904 into ZeusLN:master Apr 8, 2023
@kaloudis kaloudis deleted the component-amount-input branch April 8, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants