Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Header #1401

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Components: Header #1401

merged 2 commits into from
Apr 3, 2023

Conversation

kaloudis
Copy link
Contributor

Description

New component: Header. Built off of Header from react-native-elements

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis force-pushed the component-header branch 2 times, most recently from 776432c to 69e20b8 Compare March 26, 2023 21:39
@kaloudis kaloudis marked this pull request as ready for review March 26, 2023 23:12
@kaloudis kaloudis force-pushed the component-header branch 3 times, most recently from de2e2ce to 917063c Compare March 27, 2023 00:10
@kaloudis kaloudis added this to the v0.7.5 milestone Mar 27, 2023
@kaloudis kaloudis force-pushed the component-header branch 2 times, most recently from 1399db1 to d24fd5e Compare April 1, 2023 04:06
@kaloudis kaloudis requested a review from shubhamkmr04 April 1, 2023 04:18
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 6e24a2c into ZeusLN:master Apr 3, 2023
@kaloudis kaloudis deleted the component-header branch April 3, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants