Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockscreen: include back button when in POS mode #2449

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Oct 1, 2024

Description

When in POS mode, a back button did not appear on the Lockscreen. This would cause users to either have to brick ZEUS or restart the app if they did not know the password.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.1 milestone Oct 1, 2024
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some doubts here:

  1. why are we showing POS screen even if the app is locked.
  2. And If we decide to do it and ask for passphrase when user wants to go on Menu or wants to turn off POS mode,
  • In both cases, user gets back on the POS view (it will just turn off POS mode even when user just wanted to go on Menu)
  • And after that, once user turn off the POS again, the user again gets redirected to passphrase for everything like before.
    The flow is kinda confusing.
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-02.at.17.19.54.mp4

@kaloudis
Copy link
Contributor Author

kaloudis commented Oct 2, 2024

I have some doubts here:

1. why are we showing POS screen even if the app is locked.

2. And If we decide to do it and ask for passphrase when user wants to go on `Menu` or wants to turn off POS mode,


* In both cases, user gets back on the POS view (it will just turn off POS mode even when user just wanted to go on `Menu`)

* And after that, once user turn off the POS again, the user again gets redirected to passphrase for everything like before.
  The flow is kinda confusing.

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-02.at.17.19.54.mp4

The idea is that you can have a POS set up for employees without giving them access to the full wallet which is protected behind the password.

I am up for refining the flow here otherwise but not exactly sure on design. Let's move this to a ticket.

@kaloudis kaloudis merged commit 247b8b6 into ZeusLN:master Oct 2, 2024
3 checks passed
@kaloudis kaloudis deleted the lockscreen-pos branch October 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants