Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify memo handling for sent and received payments (invoice and payment) #2723

Merged

Conversation

myxmaster
Copy link
Contributor

Description

In #2634 I forgot to look at the receiving side, so now

  • Invoice.ts handles keysend messages and regular memos in a single getter getMemo() instead of using a separate getter getKeysendMessage() (like we have it in Payment.ts).
  • Activity.tsx uses item.getMemo instead of item.memo for invoice case as well (like payment case).
  • Invoice.tsx does not show duplicate memos, and no memo row at all if memo doesn't exist (like we have it in Payment.tsx).
    -> Memo handling and displaying is now consistent between sent and received payments.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis requested a review from shubhamkmr04 January 9, 2025 16:26
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaloudis kaloudis added this to the v0.9.5 milestone Jan 10, 2025
@kaloudis kaloudis added Keysend Activity Activity view labels Jan 10, 2025
@kaloudis kaloudis merged commit 108263b into ZeusLN:master Jan 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Activity Activity view Keysend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants