Activity: improve performance

[myxmaster]

Description

• Loading indicator removed from multiple places in ActivityStore (that alone results in less renderings), and used in Activity directly so it is now correctly displayed while loading (now it also includes setFilters() which also takes some time)
  • Removed usage of loading in ActivityFilter since it had no effect
• removed await for Storage.setItem(ACTIVITY_FILTERS_KEY, filters) in setFilters() to avoid delay of rendering
• Preparations of setFilters() now done before updating observable filteredActivity (outdated note... I was playing around with it, but because of "@action" decorator it doesn't trigger multiple renders anyway)
• Now using React.memo to avoid re-renderings of ListItems

Tested with LNC connection to a real node (~650 items in Activity) on emulator.
Rendering time before this PR: 18.54s (avg of 3 runs)
Rendering time after this PR: 11.06s (avg of 3 runs)
=> This is pretty significant because only fetching data from backend is around 4.x seconds.

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (CLNRest)
• LndHub
• [DEPRECATED] Core Lightning (c-lightning-REST)
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[AndySchroder]

Rendering time before this PR: 11.06s (avg of 3 runs)
Rendering time afterthis PR: 18.54s (avg of 3 runs)
=> This is pretty significant because only fetching data from backend is around 4.x seconds.

Do you have this backwards?

[myxmaster]

Yep, edited.

[kaloudis]

tACK

great PR! Putting this into v0.9.5