Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LND] Allow spending of unconfirmed coins #956

Merged
merged 4 commits into from
Apr 27, 2022

Conversation

deregs
Copy link
Contributor

@deregs deregs commented Apr 22, 2022

Description

Relates to issue: #949

Sets spend_unconfirmed to true for the following LND routes:

Quickly tested and it works for me, but could use more eyes on this.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Other

Checklist

  • I’ve run npm run tsc and made sure my code compiles correctly
  • I’ve run npm run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run npm run prettier and made sure my code is formatted correctly
  • I’ve run npm run test and made sure all of the tests pass

Testing

If you added new functionality or fixed a bug, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND
  • c-lightning-REST
  • spark
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run npm install after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and package-lock.json have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis
Copy link
Contributor

Unless you explicitly add the flag to sendCoins and openChannels in backends/LND.ts this will only allow unconfirmed coins to be spent when their UTXOs are specified. I think that is the intended behavior so I think we should be good.

@deregs
Copy link
Contributor Author

deregs commented Apr 23, 2022

Unless you explicitly add the flag to sendCoins and openChannels in backends/LND.ts this will only allow unconfirmed coins to be spent when their UTXOs are specified. I think that is the intended behavior so I think we should be good.

Oh, I left it out by accident actually I meant to add it there, but you think that's the functionality we should go with? Only setting spend_unconfirmed true for v1/channels/stream and v2/wallet/psbt/fund?

@kaloudis kaloudis merged commit 29a23e1 into ZeusLN:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants