LND: handle commas when setting channel fees #991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some locales use commas in place of decimals and this is reflected on systems' numeric keyboards. This PR handles those commas before passing them to the LND API.
This pull request is categorized as a:
Checklist
npm run tsc
and made sure my code compiles correctlynpm run lint
and made sure my code didn’t contain any problematic patternsnpm run prettier
and made sure my code is formatted correctlynpm run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
npm install
after this PR is merged inpackage.json
andpackage-lock.json
have been properly updatedOther: