-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] respect 'defaultScope' when using scope list #16
Comments
My design at the time was,
Awesome suggest !~ I like that. 😀 |
@Zhengqbbb ah, I see. In case of
but then there's a question what about the Maybe we can just split that one into 2 options: |
A principle, if you set it to warning, then I will not hide
I think it is enough to use one, and there is no need to come up with another concept. After all, the display of custom default values here is just an example of input. |
@Zhengqbbb btw I found one bug:
At the moment we get: |
Ach wait, I forgot the message is fully static, so the |
If `defaultScope` matches the list item `value`. It will be pinned to the top of scope list link #16
The latest version 🌟(v1.2.4)🌟 should be resolve this issue request , please have a try. 💪 |
@Zhengqbbb tested, seems to work! 🎉 |
💭 Describe the feature
Currently, when you provide the list of accepted scopes in the config, you select one in prompt by moving with arrows. The first scope highlighted is the first scope provided in the list.
defaultScope
option has no effect.💡 Proposed Solution
My proposal would be to actually respect
defaultScope
, so that you can set its value to one of the accepted scopes and move it to the top of scopes list, so it becomes the first one proposed.If the
defaultScope
value is not in the scopes list, we can ignore it / show some error.The text was updated successfully, but these errors were encountered: