Integrate with Terraform #118

gohyk · 2022-02-04T03:44:29Z

This pull request will only add terraform files required to create the resources. Integration with pipeline will be done in another phase.

github-actions · 2022-02-04T03:48:08Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-island-0901fe000-118.eastasia.azurestaticapps.net

github-actions · 2022-02-19T04:54:53Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-island-0901fe000-118.eastasia.azurestaticapps.net

github-actions · 2022-03-01T15:50:33Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-island-0901fe000-118.eastasia.azurestaticapps.net

Zhiyuan-Amos

Will you be documenting down what are some of these files doing and how they are related to each other? For e.g. I see 2 .terraform.lock.hcl but I'm not sure if they are required.
Typically what's the project structure like? For e.g. I've seen projects whereby the parent directory is tf instead of terraform. I'm not too particular about it, though it'll be good if we can set it to a default name.

Overall, this looks clean! 👍 I think the next best thing we can do now is to start documenting how this entire thing works. For a newb like myself, reading the code seems like magic.

Zhiyuan-Amos · 2022-07-17T02:14:05Z

.gitignore

+# Crash log files
+crash.log
+
+# Exclude all .tfvars files, which are likely to contain sentitive data, such as
+# password, private keys, and other secrets. These should not be part of version
+# control as they are data points which are potentially sensitive and subject
+# to change depending on the environment.
+#
+*.tfvars
+
+# Ignore override files as they are usually used to override resources locally and so
+# are not checked in
+override.tf
+override.tf.json
+*_override.tf
+*_override.tf.json
+
+# Include tfplan files to ignore the plan output of command: terraform plan -out=tfplan
+*tfplan*
+
+# Ignore CLI configuration files
+.terraformrc
+terraform.rc


I understand you referenced this from an online source, but I'm wondering if it seems like there's some inconsistency in the comments e.g. some start with Ignore, Exclude and Include.

Zhiyuan-Amos · 2022-07-17T02:16:55Z

terraform/terraform-create-resource/cosmosdb.tf

+    resource_group_name                   = azurerm_resource_group.rg.name
+
+    capabilities {
+    name = "EnableServerless"


incorrect indentation I think.

Also, could document down what IDE you use to work with Terraform files (VS Code with some plugin installed?)

Zhiyuan-Amos · 2022-07-17T02:17:15Z

terraform/terraform-create-resource/cosmosdb.tf

@@ -0,0 +1,43 @@
+# azurerm_cosmosdb_account.db:


Is this comment required?

Zhiyuan-Amos · 2022-07-17T02:17:28Z

terraform/terraform-create-resource/cosmosdb.tf

+    # Only one free tier cosmosDB per subscription
+    # enable_free_tier                      = true


good comment

Zhiyuan-Amos · 2022-07-17T02:18:09Z

terraform/terraform-create-resource/cosmosdb.tf

+        zone_redundant    = false
+    }
+
+    timeouts {}


are empty tags required, or can this entire line be removed?

Zhiyuan-Amos · 2022-07-17T02:26:59Z

terraform/terraform-create-resource/main.tf

+resource "random_uuid" "test" {
+}


does the auto-indentation cause this statement to take up 2 lines? Just checking

Zhiyuan-Amos · 2022-07-17T02:27:39Z

terraform/terraform-create-resource/variables.tf

+  default = "southeastasia"
+  description   = "Location of the resource group."


indentation of = is off

Zhiyuan-Amos · 2022-07-17T02:27:47Z

terraform/terraform-create-resource/variables.tf

@@ -0,0 +1,11 @@
+variable "prefix" {
+  default       = "test"


indentation of = looks weird

Zhiyuan-Amos · 2022-07-17T02:27:53Z

terraform/terraform-create-resource/variables.tf

+variable "prefix" {
+  default       = "test"
+}
+


additional new line

Zhiyuan-Amos · 2022-07-17T02:28:51Z

terraform/terraform-remote-state/variables.tf

+# Shortnames for regions can be found here:
+# https://github.com/claranet/terraform-azurerm-regions/blob/master/REGIONS.md


I notice this being repeated in the other variables.tf file as well. I wonder if this should be documented in a centralised location instead.

gohyk · 2022-07-20T16:19:23Z

Will you be documenting down what are some of these files doing and how they are related to each other? For e.g. I see 2 .terraform.lock.hcl but I'm not sure if they are required.

I will write up a documenting a general guide on terraform as a README/Wiki for this. As for .terraform.lock.hcl I shall include it in .gitignore file. This file may cause issues when running terraform locally on different OS. The discussion can be found here: https://stackoverflow.com/questions/67963719/should-terraform-lock-hcl-be-included-in-the-gitignore-file

Zhiyuan-Amos · 2022-07-21T15:06:01Z

The discussion can be found here: https://stackoverflow.com/questions/67963719/should-terraform-lock-hcl-be-included-in-the-gitignore-file

nice

gohyk requested a review from Zhiyuan-Amos February 4, 2022 03:44

gohyk self-assigned this Feb 4, 2022

gohyk force-pushed the gohyk-terraform-add branch from d744beb to 2699abb Compare February 27, 2022 10:30

Zhiyuan-Amos force-pushed the master branch 2 times, most recently from 331ade3 to d7fa9e3 Compare April 19, 2022 07:55

Zhiyuan-Amos force-pushed the master branch from 39f77b8 to c642e4b Compare April 22, 2022 13:06

gohyk force-pushed the gohyk-terraform-add branch from 431bd04 to 63eaa83 Compare May 7, 2022 17:56

Zhiyuan-Amos force-pushed the master branch 7 times, most recently from 49259a9 to 2e83a7a Compare May 10, 2022 08:33

Yongkiat Goh added 12 commits May 11, 2022 22:44

Initial commit

65e2394

Change publish profile reference

890ba58

Add workflow job dependencies

22a3ece

Update ARM env scope

ca49b09

Add Az CLI login step

913bea6

Upgrade tf azurerm version

725e3f4

Remove duplicate workflow

09b3b3b

Change TF auth secrets

d3f1893

Fix workflow errors on fromJSON cmdlet

56ebc85

Change TF auth secrets using pwsh

2acfb87

Upgrade tf azurerm version to 2.91.0

ec476c4

Update Azure auth

9256501

gohyk force-pushed the gohyk-terraform-add branch from dec3c1d to 9256501 Compare May 11, 2022 14:44

Yongkiat Goh added 5 commits July 8, 2022 14:57

Add couple-api functionapp

042a6f7

Revert changes on azure-messaging-function workflow

c8e7619

Merge remote-tracking branch 'origin/master' into gohyk-terraform-add

986a7de

Remove terraform workflow

bcb0ce6

Clean up pull request

71da460

gohyk marked this pull request as ready for review July 14, 2022 02:32

Zhiyuan-Amos reviewed Jul 17, 2022

View reviewed changes

Cleanup indents

6e58f38

Yongkiat Goh added 8 commits July 25, 2022 23:33

Remove .terraform.lock.hcl

604f814

Update variables conventions

2733308

Update naming convention for region variable

e1f053c

Change resource naming according to cloud adoption practices

bf94b57

Fix remote reference

acdd874

Add terraform docs

89ccceb

fix grammar

f0a4675

Update docs

c9aec87

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate with Terraform #118

Integrate with Terraform #118

gohyk commented Feb 4, 2022 •

edited

Loading

github-actions bot commented Feb 4, 2022

github-actions bot commented Feb 19, 2022

github-actions bot commented Mar 1, 2022

Zhiyuan-Amos left a comment

Zhiyuan-Amos Jul 17, 2022

Zhiyuan-Amos Jul 17, 2022

Zhiyuan-Amos Jul 17, 2022

Zhiyuan-Amos Jul 17, 2022

Zhiyuan-Amos Jul 17, 2022

Zhiyuan-Amos Jul 17, 2022

Zhiyuan-Amos Jul 17, 2022

Zhiyuan-Amos Jul 17, 2022

Zhiyuan-Amos Jul 17, 2022

Zhiyuan-Amos Jul 17, 2022

gohyk commented Jul 20, 2022

Zhiyuan-Amos commented Jul 21, 2022

		# Only one free tier cosmosDB per subscription
		# enable_free_tier = true

		default = "southeastasia"
		description = "Location of the resource group."

		# Shortnames for regions can be found here:
		# https://github.com/claranet/terraform-azurerm-regions/blob/master/REGIONS.md

Integrate with Terraform #118

Are you sure you want to change the base?

Integrate with Terraform #118

Conversation

gohyk commented Feb 4, 2022 • edited Loading

github-actions bot commented Feb 4, 2022

github-actions bot commented Feb 19, 2022

github-actions bot commented Mar 1, 2022

Zhiyuan-Amos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gohyk commented Jul 20, 2022

Zhiyuan-Amos commented Jul 21, 2022

gohyk commented Feb 4, 2022 •

edited

Loading