Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: radio mini #1139

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Conversation

Miller-Wang
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Aug 28, 2023

Someone is attempting to deploy a commit to the ZhongAnTech Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

😭 Deploy PR Preview failed.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (fc02c63) 86.09% compared to head (0faec9f) 86.01%.

❗ Current head 0faec9f differs from pull request most recent head 647dda3. Consider uploading reports for the commit 647dda3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1139      +/-   ##
==========================================
- Coverage   86.09%   86.01%   -0.08%     
==========================================
  Files         244      245       +1     
  Lines        5558     5563       +5     
  Branches     1362     1315      -47     
==========================================
  Hits         4785     4785              
- Misses        767      772       +5     
  Partials        6        6              
Files Coverage Δ
packages/zarm/src/index.mini.ts 0.00% <0.00%> (ø)
packages/zarm/src/radio/index.mini.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,76 @@
import { createBEM } from '@zarm-design/bem';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件应该 h5 和 小程序共用

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已移除

const textRender = props.children && <span className={bem('text')}>{props.children}</span>;

const iconRender = (
<span className={bem('icon')}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尽量使用 taro/components 下面的 组件代替

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已替换

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants