fix: custome className added to container #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for zarm ready! Built with commit bde8945 |
JeromeLin
reviewed
May 15, 2020
components/toast/demo.md
Outdated
Comment on lines
8
to
25
| class Demo extends React.Component { | ||
| render() { | ||
| return ( | ||
| <> | ||
| <Cell | ||
| description={ | ||
| <Button | ||
| size="xs" | ||
| onClick={() => { | ||
| Toast.show('默认3秒自动关闭'); | ||
| }} | ||
| > | ||
| 开启 | ||
| </Button> | ||
| } | ||
| > | ||
| 开启 | ||
| </Button> | ||
| } | ||
| > | ||
| 普通 | ||
| </Cell> | ||
| 普通 | ||
| </Cell> |
There was a problem hiding this comment.
之前要在demo里使用this.ref来测试挂载节点的问题，所以改成了Class形式，然后就没改回来了，如果要和之前保持统一的话，我这次一并修改下。
JeromeLin
reviewed
May 15, 2020
components/utils/getMountNode.tsx
Outdated
| @@ -0,0 +1,20 @@ | |||
| const getMountNode = (props: any): HTMLElement => { | |||
There was a problem hiding this comment.
参数就别用props了吧，直接传container了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.