Skip to content

Commit

Permalink
add ApplicationId to Registered Server Update params (Azure#31342)
Browse files Browse the repository at this point in the history
  • Loading branch information
stefong99 authored Nov 19, 2024
1 parent 14f4f6b commit 69a5c08
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE/control_plane_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ What's the purpose of this PR? Check the specific option that applies. This is *

- [ ] New resource provider.
- [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to [OpenAPI specs PR creation guidance](https://aka.ms/azsdkdocs/createopenapispec)).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [x] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix OpenAPI spec quality issues in S360.
- [ ] Convert existing [OpenAPI spec to TypeSpec spec](https://aka.ms/typespec/conversion) (do not combine this with implementing changes for a new API version).
- [ ] Other, please clarify:
Expand All @@ -26,8 +26,8 @@ What's the purpose of this PR? Check the specific option that applies. This is *
To merge this PR, you **must** go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

- [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [ ] I have reviewed following [Resource Provider guidelines](https://aka.ms/rpguidelines), including
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [x] I have reviewed following [Resource Provider guidelines](https://aka.ms/rpguidelines), including
[ARM resource provider contract](https://aka.ms/azurerpc) and
[REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md) (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"serverId": "080d4133-bdb5-40a0-96a0-71a6057bfe9a",
"parameters": {
"properties": {
"identity": true
"identity": true,
"applicationId": "120d4132-bcd5-40a0-96a0-71a6057ebf0c"
}
},
"api-version": "2022-09-01"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3806,6 +3806,10 @@
"identity": {
"type": "boolean",
"description": "Apply server with newly discovered ApplicationId if available."
},
"applicationId": {
"type": "string",
"description": "Apply server with new ServicePrincipal Id"
}
}
},
Expand Down
17 changes: 17 additions & 0 deletions specification/storagesync/resource-manager/sdk-suppressions.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
suppressions:
azure-sdk-for-python:
- package: azure-mgmt-storagesync
breaking-changes:
- Method `MicrosoftStorageSync.__init__` parameter `base_url` changed default value from `None` to `str`
- Method `ServerEndpoint.__init__` parameter `initial_download_policy` changed default value from `None` to `str`
- Method `ServerEndpoint.__init__` parameter `local_cache_mode` changed default value from `None` to `str`
- Method `ServerEndpointCreateParameters.__init__` parameter `initial_download_policy` changed default value from `None` to `str`
- Method `ServerEndpointCreateParameters.__init__` parameter `local_cache_mode` changed default value from `None` to `str`
- Method `ServerEndpointCreateParameters.__init__` parameter `tier_files_older_than_days` changed default value from `None` to `int`
- Method `ServerEndpointCreateParameters.__init__` parameter `volume_free_space_percent` changed default value from `None` to `int`
- Method `ServerEndpointUpdateParameters.__init__` parameter `local_cache_mode` changed default value from `None` to `str`
- Model `StorageSyncApiError` deleted or renamed its instance variable `inner_error`
azure-sdk-for-js:
- package: "@azure/arm-storagesync"
breaking-changes:
- Interface StorageSyncApiError no longer has parameter innerError

0 comments on commit 69a5c08

Please sign in to comment.