Fix CircularBuffer reporting wrong readable/writable length #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add bounds test for CircularBuffer
buffer.full was never set in this function, but it was in write_assume_capacity.
Grazfather
approved these changes
Jan 5, 2026
tact1m4n3
approved these changes
Jan 5, 2026
Contributor
Author
|
My comment about this fixing the rp2xxx cdc example is incorrect, the example still doesn't work with this change. |
mattnite
approved these changes
Jan 5, 2026
Copper280z
added a commit
to Copper280z/microzig
that referenced
this pull request
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CircularBuffer struct was previously reporting the wrong readable/writable length, which allowed the user to overwrite valid parts of the buffer. This is the cause of the rp2xxx usb-cdc example failing to print the whole string.
This adds a test which previously failed, now passes, along with the actual fix, which is just to set the .full member variable to true in the write function when the buffer is full.