Skip to content

Conversation

@Grazfather
Copy link
Collaborator

Tested on my wch branch on top of #838

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 7 issues on changed lines in 3 files:

  • drivers/display/sharp_memory_lcd.zig: 1 issue
  • drivers/framework.zig: 1 issue
  • port/raspberrypi/rp2xxx/src/hal/usb.zig: 5 issues
ℹ️ Additional issues on unchanged lines
The following 12 issue(s) exist but are not on lines changed in this PR:

drivers/framework.zig:32: Suggestion: Rename `Keyboard_Matrix` to `KeyboardMatrix`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:33: Suggestion: Rename `Debounced_Button` to `DebouncedButton`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:34: Suggestion: Rename `Rotary_Encoder` to `RotaryEncoder`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:66: Suggestion: Rename `IO_expander` to `IO_Expander`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:78: Suggestion: Rename `Cyw43_Spi` to `CYW43_SPI`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:79: Suggestion: Rename `Cyw43_Bus` to `CYW43_Bus`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:80: Suggestion: Rename `Cyw43_Runner` to `CYW43_Runner`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:212: Suggestion: Rename `Datagram_Device` to `DatagramDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:213: Suggestion: Rename `Stream_Device` to `StreamDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:215: Suggestion: Rename `Clock_Device` to `ClockDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:216: Suggestion: Rename `Block_Memory` to `BlockMemory`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/raspberrypi/rp2xxx/src/hal/usb.zig:188: TODO style comments need to have a linked microzig issue on the same line.

@github-actions github-actions bot dismissed their stale review January 10, 2026 12:38

Updating with new lint results

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 2 issues on changed lines in 2 files:

  • drivers/display/sharp_memory_lcd.zig: 1 issue
  • drivers/framework.zig: 1 issue
ℹ️ Additional issues on unchanged lines
The following 11 issue(s) exist but are not on lines changed in this PR:

drivers/framework.zig:32: Suggestion: Rename `Keyboard_Matrix` to `KeyboardMatrix`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:33: Suggestion: Rename `Debounced_Button` to `DebouncedButton`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:34: Suggestion: Rename `Rotary_Encoder` to `RotaryEncoder`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:66: Suggestion: Rename `IO_expander` to `IO_Expander`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:78: Suggestion: Rename `Cyw43_Spi` to `CYW43_SPI`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:79: Suggestion: Rename `Cyw43_Bus` to `CYW43_Bus`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:80: Suggestion: Rename `Cyw43_Runner` to `CYW43_Runner`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:212: Suggestion: Rename `Datagram_Device` to `DatagramDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:213: Suggestion: Rename `Stream_Device` to `StreamDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:215: Suggestion: Rename `Clock_Device` to `ClockDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:216: Suggestion: Rename `Block_Memory` to `BlockMemory`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.

@github-actions github-actions bot dismissed their stale review January 10, 2026 12:40

Updating with new lint results

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

ℹ️ Additional issues on unchanged lines
The following 11 issue(s) exist but are not on lines changed in this PR:

drivers/framework.zig:32: Suggestion: Rename `Keyboard_Matrix` to `KeyboardMatrix`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:33: Suggestion: Rename `Debounced_Button` to `DebouncedButton`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:34: Suggestion: Rename `Rotary_Encoder` to `RotaryEncoder`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:66: Suggestion: Rename `IO_expander` to `IO_Expander`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:78: Suggestion: Rename `Cyw43_Spi` to `CYW43_SPI`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:79: Suggestion: Rename `Cyw43_Bus` to `CYW43_Bus`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:80: Suggestion: Rename `Cyw43_Runner` to `CYW43_Runner`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:212: Suggestion: Rename `Datagram_Device` to `DatagramDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:213: Suggestion: Rename `Stream_Device` to `StreamDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:215: Suggestion: Rename `Clock_Device` to `ClockDevice`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
drivers/framework.zig:216: Suggestion: Rename `Block_Memory` to `BlockMemory`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.

@Grazfather Grazfather merged commit 5a70ae6 into main Jan 11, 2026
56 checks passed
@Grazfather Grazfather deleted the nice_view branch January 11, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants