making config more posix friendly. #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
Removed as many hardcoded values in favor of
std.posixvalues wherever possible, such asVMIN/VSTOP/VSTART/VTIME. Linux itself has annoying differences between systems.Removed baudmaps in favor of
getSpeed(baudrate: u32) ?speed_tto handle every possible enum.On miss will set
mac_nonstandard_baudif macos, else returnerror.UnsupportedBaudrate.Added safeSet function to check to see if a field is valid before setting it as termios seems to be all over the place.
Added every flag in zig lib for cflag and iflag, as well as what my current best guess is at what they should be.
Added timeout to Config, simple logic to support it in posix. Windows wip.
configureSerialPort should be pretty close to being system agnostic.
Few macs on the way for build runners