Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 211 (Add Kosaraju Algorithm) #219

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Conversation

sarthak17jain
Copy link
Contributor

Fixed issue #211 (Add Kosaraju Algorithm)
Updated Graph.hpp by adding kosaraju() function.
@ZigRazor please review the changes and accept the pull request.

@github-actions github-actions bot added the core something about core label Oct 1, 2022
@ghost
Copy link

ghost commented Oct 1, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Copy link
Owner

@ZigRazor ZigRazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the comments done and then i can approve it

include/Graph/Graph.hpp Outdated Show resolved Hide resolved
Made the requested changes.
Corrected the commenting.
Moved the Doxygen documentation before the function declaration and corrected the documentation of the other function that I messed up earlier.
Copy link
Owner

@ZigRazor ZigRazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@ZigRazor
Copy link
Owner

ZigRazor commented Oct 3, 2022

This PR Fix #211

@ZigRazor ZigRazor linked an issue Oct 3, 2022 that may be closed by this pull request
@ZigRazor ZigRazor added this to the Algorithm Implementation milestone Oct 3, 2022
@ZigRazor ZigRazor self-assigned this Oct 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #219 (bdb9d8a) into master (f5938c3) will decrease coverage by 0.83%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   97.94%   97.10%   -0.84%     
==========================================
  Files          45       45              
  Lines        5214     5257      +43     
==========================================
- Hits         5107     5105       -2     
- Misses        107      152      +45     
Flag Coverage Δ
unittests 97.10% <0.00%> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/Graph/Graph.hpp 93.26% <0.00%> (-4.50%) ⬇️
include/Partitioning/EBV.hpp 88.05% <0.00%> (-4.48%) ⬇️
include/Partitioning/GreedyVertexCut.hpp 86.73% <0.00%> (-3.07%) ⬇️
include/Partitioning/HDRF.hpp 78.02% <0.00%> (-1.10%) ⬇️
include/Partitioning/EdgeBalancedVertexCut.hpp 84.31% <0.00%> (+9.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ZigRazor ZigRazor merged commit 1235fd0 into ZigRazor:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kosaraju Algorithm
3 participants