Implement kahn's algorithm for topological sorting #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
👇 Click on the image for a new way to code review
Legend |
|
@ZigRazor After implementation of Kahn's algorithm, I realised that the implementation of |
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 96.92% 96.86% -0.07%
==========================================
Files 48 49 +1
Lines 5895 6065 +170
==========================================
+ Hits 5714 5875 +161
- Misses 181 190 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ZigRazor
approved these changes
Jan 10, 2023
ZigRazor
added a commit
that referenced
this pull request
Mar 21, 2023
* introduce topological sort for graph (#247) * implement topological sort based on dfs * add benchmark for topological sort * add basic test for topological sort Co-authored-by: suncanghuai <suncanghuai@gmail.com> * Fix typo in link specification (#248) This PR removes an additional space character between link text and link URL, which caused faulty formatting of the README.md file. * introduce WeightBalancedLibra algorithm(vertex-cut graph partition) (#249) * implement WeightBalancedLibra algorithm based on paper pseudocode * add weight-related apis for class CoordinatedPartitionState * adjust set operations of class CoordinatedRecord * append a testcase in PartitionTest.cpp for WB-Libra Co-authored-by: suncanghuai <suncanghuai@hesaitech.com> * Update README.md * Update README.md * Install the CodeSee workflow. Learn more at https://docs.codesee.io (#250) Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com> * * implement multi-thread bfs (#252) * add testcases for multi-thread bfs(in BFSTest.cpp) * add benchmark for multi-thread bfs(in BFS_BM.cpp) Co-authored-by: suncanghuai <suncanghuai@gmail.com> * Update Readme Roadmap * Implement best first search (#254) * first implementation and tests * add docs and minor changes * minor change * minor change * Update README.md * Update README.md * Include best first search test (#258) * Update README for best first search algorithm (#257) * Update README for best first search algorithm * minor change * minor change * minor review changes * Implement kahn's algorithm for topological sorting (#259) * Improved return type for Kosaraju's algoritm + tests (#260) * custom return type for kosaraju() * Tests for Kosaraju's algorithm * fixed minor issues * fixed merge issue * Update Road Map * Update README.md * Reworked Cmake Signed-off-by: GitHub <noreply@github.com> * Add partition Example ( HDRF ) Signed-off-by: GitHub <noreply@github.com> * Corrected Partition Class Fix #263 Signed-off-by: GitHub <noreply@github.com> * Update Readme for Roadmap Signed-off-by: GitHub <noreply@github.com> * Corrected Cmake for old Example Signed-off-by: GitHub <noreply@github.com> * Update cmake.yml * Update benchmark_pr.yml * Update benchmark.yml * Update Code_Coverage.yml * Correction for Graph.hpp Signed-off-by: GitHub <noreply@github.com> * Update Code_Coverage.yml Parallel compilation * Update benchmark.yml parallel compilation * Update benchmark_pr.yml parallel compilation * Update cmake.yml parallel compilation * Update codeql-analysis.yml remove useless steps: - manually installed google test and benchmark * Create .github/workflows/super-linter.yml Added Super-Linter * Update super-linter.yml * Create .clang-format * Reformatted Files with clang-format with syle "Google" Signed-off-by: GitHub <noreply@github.com> * Delete super-linter.yml * Create .github/workflows/codeql.yml * Delete codeql-analysis.yml * Update README.md * Create .github/workflows/codacy.yml * Create .github/workflows/snyk-security.yml * Update snyk-security.yml * Delete snyk-security.yml --------- Signed-off-by: GitHub <noreply@github.com> Co-authored-by: ARockHammer <37604654+SunCangHuai@users.noreply.github.com> Co-authored-by: suncanghuai <suncanghuai@gmail.com> Co-authored-by: David Chocholatý <chocholaty.david@protonmail.com> Co-authored-by: suncanghuai <suncanghuai@hesaitech.com> Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com> Co-authored-by: Pradeep Krishnamurthy <pradkrish84@gmail.com> Co-authored-by: David Sapienza <david.sapienza@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #237