Added reverseDirectedGraph() function #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
include/Graph/Graph.hpp
Outdated
| if (!isDirectedGraph()) { | ||
| throw std::runtime_error(ERR_UNDIR_GRAPH); | ||
| } | ||
| auto edgeSet = Graph<T>::getEdgeSet(); |
Check warning
Code scanning / Cppcheck (reported by Codacy)
Local variable 'edgeSet' shadows outer variable
| * This function reverse the direction of the edges in a directed graph | ||
| * | ||
| */ | ||
| virtual void reverseDirectedGraph(); |
Check warning
Code scanning / Cppcheck (reported by Codacy)
misra violation 802 with no text in the supplied rule-texts-file
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
- Coverage 97.24% 97.23% -0.01%
==========================================
Files 54 54
Lines 7793 7850 +57
==========================================
+ Hits 7578 7633 +55
- Misses 215 217 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Can you fix the warnings by Code Scanning? |
sbaldu
approved these changes
Jun 11, 2023
|
Merge LGTM |
nrkramer
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reverseDirectedGraph() function (#315) to reverse all connection in a directed graph and related tests.