Add tests for cycles in directed graphs

[sbaldu]

Add tests to the GraphTest testcase to check that the hashing function used for the sets of edges doesn't cause problems with directed edges forming a cycle (issue #324)

[ghost]

👇 Click on the image for a new way to code review

Legend

[codecov]

Codecov Report

Merging #325 (a0ce040) into master (4d60bf6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   97.24%   97.25%           
=======================================
  Files          54       54           
  Lines        7907     7934   +27     
=======================================
+ Hits         7689     7716   +27     
  Misses        218      218           

Flag	Coverage Δ
unittests	97.25% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
test/GraphTest.cpp	100.00% <100.00%> (ø)

[ZigRazor]

Sorry @sbaldu , these tests are passed?

[sbaldu]

Sorry @sbaldu , these tests are passed?

Yes they both pass

[ZigRazor]

what do you think @nrkramer? These tests should demostrate that the issue #324 could be closed, right?

[nrkramer]

Looks good. Thanks @sbaldu !! This definitely closes that issue out.

However, I'd like to refer you to #326, which demonstrates that sometimes unique edges are not added.

I closed the directed cyclic edges issue, since it seems the issue I'm running into may be separate.

[ZigRazor]

I merge this PR even if the problem reported in #324 and the demostration on PR #326 is not solver.
In any case this PR add some tests, that are correct.

[sbaldu]

Ok @ZigRazor, thanks