Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganizzation of Code #385

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Reorganizzation of Code #385

merged 7 commits into from
Jan 9, 2024

Conversation

ZigRazor
Copy link
Owner

@ZigRazor ZigRazor commented Jan 9, 2024 •
edited
Loading

These modifies does not broke the interfaces, but are significatly reworked the organizations of files.
This PR is related also to issue #364

@ZigRazor ZigRazor requested review from nrkramer and sbaldu January 9, 2024 08:38
@ZigRazor ZigRazor added the enhancement New feature or request label Jan 9, 2024
@ghost
Copy link

ghost commented Jan 9, 2024 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2024
View reviewed changes
include/CXXGraph/Graph/IO/IOUtility_impl.hpp

unsigned int zippedBytes;
zippedBytes =
gzwrite(outFileZ, content_ptr, (unsigned int)strlen(content_ptr));

Check notice

Code scanning / Flawfinder (reported by Codacy)

Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). Note

Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126).
@ZigRazor ZigRazor linked an issue Jan 9, 2024 that may be closed by this pull request
Break out algorithms in Graph.hpp into Algorithms/ folder #364
Closed
@ZigRazor
Corrected some static analisys errors
18b5bd3 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
sbaldu
sbaldu approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@sbaldu sbaldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think it's a good idea to separate declarations and implementations, and also to put every algorithm in a single header. It will be much easier and quicker to find stuff now.

@sbaldu
Copy link
Collaborator

sbaldu commented Jan 9, 2024

Just out of curiosity, why are some files .h and others .hpp?

@ZigRazor
Corrected an issue for input/output test
809c2e6 
Signed-off-by: ZigRazor <zigrazor@gmail.com>
@ZigRazor
Copy link
Owner Author

ZigRazor commented Jan 9, 2024

Just out of curiosity, why are some files .h and others .hpp?

Because the .h file contains only declaration, and the .hpp file contains the template implementations

@ZigRazor ZigRazor self-assigned this Jan 9, 2024
@ZigRazor ZigRazor merged commit 12a8fa2 into master Jan 9, 2024
11 of 16 checks passed
@ZigRazor ZigRazor deleted the Reorganizzation branch January 9, 2024 09:39
@sbaldu
Copy link
Collaborator

sbaldu commented Jan 9, 2024

Just out of curiosity, why are some files .h and others .hpp?

Because the .h file contains only declaration, and the .hpp file contains the template implementations

Ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbaldu sbaldu sbaldu approved these changes

@nrkramer nrkramer Awaiting requested review from nrkramer

Assignees

@ZigRazor ZigRazor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Break out algorithms in Graph.hpp into Algorithms/ folder
2 participants
@ZigRazor @sbaldu