Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds are broken due to MSVC fold expression bug #416

Merged
merged 3 commits into from
Apr 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions include/CXXGraph/Graph/Algorithm/Boruvka_impl.hpp
Original file line number Diff line number Diff line change
@@ -187,16 +187,16 @@
// Else check if current edge is closer to previous
// cheapest edges of set1 and set2
if (cheapest[set1] == INT_MAX ||
(edgeWeight[cheapest[set1]] > edgeWeight[edgeId]) ||
(edgeWeight[cheapest[set1]] == edgeWeight[edgeId] && cheapest[set1] > edgeId)
)
cheapest[set1] = edgeId;
(edgeWeight[cheapest[set1]] > edgeWeight[edgeId]) ||
(edgeWeight[cheapest[set1]] == edgeWeight[edgeId] &&
cheapest[set1] > edgeId))
cheapest[set1] = edgeId;

if (cheapest[set2] == INT_MAX ||
(edgeWeight[cheapest[set2]] > edgeWeight[edgeId]) ||
(edgeWeight[cheapest[set2]] == edgeWeight[edgeId] && cheapest[set2] > edgeId)
)
cheapest[set2] = edgeId;
(edgeWeight[cheapest[set2]] > edgeWeight[edgeId]) ||
(edgeWeight[cheapest[set2]] == edgeWeight[edgeId] &&
cheapest[set2] > edgeId))

Check warning on line 198 in include/CXXGraph/Graph/Algorithm/Boruvka_impl.hpp

Codecov / codecov/patch

include/CXXGraph/Graph/Algorithm/Boruvka_impl.hpp#L198

Added line #L198 was not covered by tests
cheapest[set2] = edgeId;
}

// iterate over all the vertices and add picked
Loading