#486 Attempts to fix cmake build on windows, msvc #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfkleach
reviewed
Jan 7, 2025
test/CMakeLists.txt
Outdated
|
|
||
| endif(CODE_COVERAGE) | ||
| endif(CODE_COVERAGE) | ||
| endif() |
sfkleach
reviewed
Jan 7, 2025
| @@ -41,7 +38,7 @@ jobs: | |||
| # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type | |||
| run: | | |||
| if [ ${{ matrix.os }} == 'windows-latest' ]; then | |||
| cmake -DTEST=ON -Dgtest_disable_pthreads=ON -B ${{github.workspace}}/build | |||
| cmake -DTEST=ON -Dgtest_disable_pthreads=ON -B ./build | |||
There was a problem hiding this comment.
Is this correct? Could you explain why?
There was a problem hiding this comment.
Added a comment to explain.
sfkleach
reviewed
Jan 7, 2025
.github/workflows/cmake.yml
Outdated
| @@ -2,10 +2,7 @@ name: CMake | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [ master ] | |||
There was a problem hiding this comment.
I am unsure that removing the branch restriction is right - do we know if the team uses direct commit to master or TBD?
sfkleach
approved these changes
Jan 7, 2025
ZigRazor
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good pull request has the following information:
A reference to a related issue in your repository.
Closes issue Windows build #486.
A description of the changes proposed in the pull request.
Changes in workflow file to not include windows path separators in call to CMake.
Changes in CMake files to not use gcc/clang arguments to compiler invocation.
@mentions of the person or team responsible for reviewing proposed changes. ( optional )