Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc2: Adding colossus war council upgrade -- fire lance #256

Merged
merged 9 commits into from
Aug 9, 2024

Conversation

MatthewMarinets
Copy link
Contributor

@MatthewMarinets MatthewMarinets commented Aug 9, 2024

Add Colossus war council upgrade -- Fire Lance. Nerfed colossi don't set the ground on fire, upgrade returns the effect.

It turns out my Zealot death animation swap didn't actually work, it just wasn't noticeable on Zealots. I figured out how to make it work properly on colossus, then backported the fix to Zealots.

Progress on #152
Pairs with client PR #282

Without upgrade

image
image
image
image
image
image
image

With upgrade

image
image
image
image
image
image

@MatthewMarinets MatthewMarinets force-pushed the mm/war_council_colossus branch from 2b71c0f to c2ba5d6 Compare August 9, 2024 19:49
@Ziktofel Ziktofel merged commit 005d1f5 into Ziktofel:sc2-next Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants