Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item name group refactor & /received filtering rework #159

Merged
merged 4 commits into from
Feb 3, 2024

Conversation

Salzkorn
Copy link

@Salzkorn Salzkorn commented Feb 3, 2024

What is this fixing or adding?

This expands existing item name groups and changes how filtering works for the /received command.

Item name groups now live in their own file, and a lot of automation for them has been added.

  • All previously existing groups still exist
  • Groups based on item flag groups are unified
    • This means "Unit" contains items from the "Unit" and "Unit 2" groups, "Armory" contains "Armory 1-6", etc.
  • Item races are groups, including "Any"
  • Items with brackets get alias groups, so eg. "Advanced Healing AI" can be used instead of "Advanced Healing AI (Medivac)"
    • This existed previously, but only for a hand-picked subset of item flag groups
    • It now checks all item names directly
    • An exception to this are items that would be ambiguous without the bracketed part (eg. "Resource Efficiency")
  • Items with parents get a single group (eg. "Zergling Items" for items with parent "Zergling")
    • The special name is used to avoid ambiguity with the parent item in YAMLs
    • This does not currently respect items with multiple potential parents

The /received command can now take a partial item name or a full group name as a filter.
This does not currently have simplified inputs for items or groups with punctuation, eg. "WILD" will not match "W.I.L.D. Missiles (Viking)", "TalDarim" will not match "Tal'Darim".

There is also not currently a user-facing way to see all possible groups. There is some ground work for filtering developer-facing groups and "obvious" groups (the bracket alias & child item groups, specifically), but this is not currently applied anywhere.

How was this tested?

Messing around with the command in the beta async.

If this makes graphical changes, please attach screenshots.

Filtering by partial name:
python_ITVc2nQd8m
Filtering by item name group:
python_Vys8nAmhwd
Showing off unified flag groups (previously, certain LotV units would not show up here):
python_Iy2LldJh3n

@Salzkorn Salzkorn requested a review from Ziktofel as a code owner February 3, 2024 17:43
@Ziktofel Ziktofel merged commit f29aa26 into Ziktofel:sc2-next Feb 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants