Scale down gas consumption #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaivaswatha
requested review from
anton-trunov,
AmritKumar,
kaikawaliu,
snowsledge and
jjcnn
|
Abandoning because scaling down at the end wouldn't work. Contracts that might complete successfully with the scaled down gas consumption may still fail with "out of gas" because we scale down only at the end. |
|
The bug can be fixed, re-opening. |
vaivaswatha
changed the title
anton-trunov
approved these changes
Jul 30, 2020
|
LGTM! Let's merge once CI is green :) |
vaivaswatha
added a commit
to Zilliqa/scilla-rtl
that referenced
this pull request
Jul 27, 2021
Point 2. in #13. Reference: Zilliqa/scilla#877
This was referenced Jul 27, 2021
vaivaswatha
added a commit
to Zilliqa/scilla-rtl
that referenced
this pull request
Aug 5, 2021
* Scale gas limit. Point 2. in #13. Reference: Zilliqa/scilla#877 * Gas charge for dynamic typecheck * Initialize a variable to avoid warning * Specify RTLD_LOCAL in SharedObject explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.