Only recursion check each library once #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve globally unique variable names from environment
|
Update: I have updated the typechecker as well, and the Polynetwork contract now works regardless of the order that the standard libraries are imported in. |
|
@anton-trunov , @vaivaswatha : I'm happy with the positive test cases, but I'm not sure I'm covering enough cases with the negative ones. If you have some ideas I'm happy to add them, but if not I think it's ready to be merged to master. |
|
Nice test cases, thanks Jacob. LGTM |
vaivaswatha
approved these changes
Dec 18, 2020
anton-trunov
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the problem with a contract importing two libraries
L1andL2butL2also importingL1.