Fix parsing of integers with leading 0s #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjcnn
approved these changes
Apr 20, 2021
|
@vaivaswatha : I've improved the test case, simplified the regexp malarkey, and added some comments as to how it works. I don't think it's that complex, TBH. However, strictly speaking this is a breaking change because someone might have relied on |
|
Anyway, I've approved the PR, so merge if you're ok with the change. |
Co-authored-by: Anton Trunov <anton@zilliqa.com>
anton-trunov
approved these changes
Apr 21, 2021
AmritKumar
added a commit
that referenced
this pull request
Apr 21, 2021
Fix parsing of integers with leading 0s (#982)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.