Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateTransaction documentation should be improved #1506

Closed
rrw-zilliqa opened this issue Sep 27, 2024 · 0 comments · Fixed by #1600
Closed

CreateTransaction documentation should be improved #1506

rrw-zilliqa opened this issue Sep 27, 2024 · 0 comments · Fixed by #1600
Assignees

Comments

@rrw-zilliqa
Copy link
Contributor

I recently had cause to implement a call to CreateTransaction from scratch and it would be nice to improve the docs:

  • CreateTransaction isn't clear on which fields are mandatory, or on how the signature is computed.
  • There is various validation (at least in zq1) on eg. address checksums that is not disclosed in the docs

I had to look at the C++ in ZQ1 to get ZQ1 to accept my txn and I shouldn't've ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant