Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetNumTxnsDSEpoch #1542

Closed
2 of 3 tasks
maxconway opened this issue Oct 2, 2024 · 0 comments · Fixed by #1634
Closed
2 of 3 tasks

GetNumTxnsDSEpoch #1542

maxconway opened this issue Oct 2, 2024 · 0 comments · Fixed by #1634
Assignees
@maxconway
Labels
area:apis Related to externally-facing APIs

Comments

@maxconway
Copy link
Contributor

TODO list

  • Write tests
  • Draft implementation
  • Finalize and merge
@maxconway maxconway added the area:apis Related to externally-facing APIs label Oct 2, 2024
@maxconway maxconway self-assigned this Oct 2, 2024
@maxconway maxconway mentioned this issue Oct 8, 2024
Open
maxconway added a commit that referenced this issue Oct 15, 2024
@maxconway
Implement GetNumTxnsTxEpoch and GetNumTxnsDSEpoch
551aa9d 
- Closes #1542
- Closes #1543
@maxconway maxconway mentioned this issue Oct 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 21, 2024
@maxconway
Implement GetNumTxnsTxEpoch and GetNumTxnsDSEpoch (#1634)
529201c 
* Implement GetNumTxnsTxEpoch and GetNumTxnsDSEpoch

- Closes #1542
- Closes #1543

* Modified behaviour of GetNumTxnsTxEpoch and GetNumTxnsDsEpoch to match zq1

- Also modified the docs for GetNumTxnsTxEpoch to be more explicit that an "epoch' is the most recent block

* Remove DB accesses from num_txns_epoch_* api calls for simplicity, fix tests

* Change unwraps to returned errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxconway maxconway

Labels
area:apis Related to externally-facing APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement GetNumTxnsTxEpoch and GetNumTxnsDSEpoch Zilliqa/zq2
1 participant
@maxconway