PREAPPS-1325 Minor improvements which are not related to the ticket #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silentsakky
requested review from
BhavinBathani,
itsmeprashant,
lavegupta,
panditsavitags,
pl12133,
sachinpatel88,
SantoshKShetty and
yashrajpchavda
as code owners
yashrajpchavda
approved these changes
Dec 26, 2018
dajay0
reviewed
Dec 26, 2018
| @@ -1356,7 +1356,7 @@ type MimePart { | |||
| contentId: String | |||
| contentType: String | |||
| contentDisposition: String | |||
| size: Int # Size in bytes | |||
| size: Float # Size in bytes | |||
There was a problem hiding this comment.
I am presuming we are going to Float as we dont have a LongInt in GQL. This might lead to some hard to find errors (failing equality, etc). More at http://www.volkerschatz.com/science/float.html.
I think we may eventually need to do a CustomScalar as suggested in graphql/graphql-spec#73. But that is a lot of work :(. Or look for a library that does it.
There was a problem hiding this comment.
yes if we have a size value which exceeds integer boundary
this change was added to put consistency as in some places we are using Float and some places it was Int, so graphql was giving conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.