ZCS-12421: Adding tags for instance and series in appointments #1418
Conversation
|
|
swaatiTelus
changed the title
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| import org.dom4j.Namespace; | |||
| import org.dom4j.QName; | |||
| import org.python.antlr.ast.Str; | |||
There was a problem hiding this comment.
is this import required
There was a problem hiding this comment.
No this is not required, I have removed it.
| @@ -856,6 +857,10 @@ private MailConstants() { | |||
| // messages | |||
| public static final String E_MIMEPART = "mp"; | |||
| public static final String E_SUBJECT = "su"; | |||
|
|
|||
| public static final String E_OP = "op"; | |||
| public static final String E_TN = "tn"; | |||
There was a problem hiding this comment.
can we be more descriptive with variable name
There was a problem hiding this comment.
Yes, edited and used more descriptive variable name
| setRecurrence(recurrence); | ||
| setRecurId(recurrenceId); | ||
| } | ||
|
|
There was a problem hiding this comment.
overload the existing constructor rather than duplicating the entire constructor code
| @@ -357,6 +416,9 @@ public static Metadata encodeMetadata(Invite inv) { | |||
| } | |||
|
|
|||
| meta.put(FN_NAME, inv.getName()); | |||
| meta.put(FN_OPERATION_TYPE, inv.getOperationType()); | |||
| meta.put(FN_TAG_COLOUR, inv.getTagColour()); | |||
|
|
|||
There was a problem hiding this comment.
Above line - meta.put(FN_NAME, inv.getName()); has also extra space. Still shall I remove the space. Please confirm.
| @@ -579,6 +641,9 @@ public static Invite decodeMetadata(int mailboxId, Metadata meta, CalendarItem c | |||
| String name = meta.get(FN_NAME, ""); | |||
| String loc = meta.get(FN_LOCATION, null); | |||
|
|
|||
| String opType = meta.get(FN_OPERATION_TYPE,null); | |||
| String tagCol = meta.get(FN_TAG_COLOUR,null); | |||
|
|
|||
There was a problem hiding this comment.
extra space, check in other part of code changes as well
| @@ -1084,6 +1084,8 @@ private static void parseInviteElementCommon(Account account, MailItem.Type type | |||
| } | |||
|
|
|||
| String name = element.getAttribute(MailConstants.A_NAME, ""); | |||
| String operationType = element.getAttribute(MailConstants.E_OP,""); | |||
| String tagColour = element.getAttribute(MailConstants.E_TN,""); | |||
There was a problem hiding this comment.
format like
element.getAttribute(MailConstants.E_OP, "");
for both
manjeetbehera
force-pushed
the
bugfix/ZCS-12421
branch
3 times, most recently
from
0a1c7b9 to
c2157a5
Compare
manjeetbehera
force-pushed
the
bugfix/ZCS-12421
branch
from
c2157a5 to
257db13
Compare
No description provided.